-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CMakeLists - separation of libraries #1767
Conversation
@knro Do we care about UNITY_BUILD? I see that it has not been tested for a long time and bugs fly. I am also not convinced that UNITY_BUILD is needed with the current capabilities of compilers and multi-threading of compilation. |
@knro I repeat the question, can I remove all Line 448 in f0228fa
|
Sorry, sure go ahead. |
There are 2 options for building: OPTION(INDI_BUILD_SHARED "Build shared library" ON)
OPTION(INDI_BUILD_STATIC "Build static library" ON) By default, they are enabled and the following libraries are created:
Shared libraries have been added. For the library I suggest for the future to make static libraries have |
@knro Ready for review. |
Looks like this causes our Launchpad debian builds to fail. Can you please check? We need an urgent fix. |
I think I have reproduced the problem. I'll analyze what's going on right now. Later, I will also add a package build to CI for the future. |
|
Fixed: #1776 |
Split the libraries into separate folders and create
CMakeLists
for each of them.